Add Star Tree unsigned-long indexing changes#17156
Merged
sachinpkale merged 1 commit intoopensearch-project:mainfrom Jan 28, 2025
Merged
Conversation
Signed-off-by: Shailesh Singh <shaileshkumarsingh260@gmail.com>
Shailesh-Kumar-Singh
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
cwperks,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
3 tasks
Contributor
|
❕ Gradle check result for 147d817: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
bharath-techie
approved these changes
Jan 28, 2025
Contributor
|
#16645 already have reviewed the original PR and I'm good with the changes. Thanks @Shailesh-Kumar-Singh for the changes. |
mgodwan
approved these changes
Jan 28, 2025
sachinpkale
approved these changes
Jan 28, 2025
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-17156-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8ec93ae4e178c391b916a721ea4884ef559fa796
# Push it to GitHub
git push --set-upstream origin backport/backport-17156-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.xThen, create a pull request where the |
3 tasks
linuxpi
pushed a commit
that referenced
this pull request
Jan 28, 2025
etolbakov
pushed a commit
to etolbakov/OpenSearch
that referenced
this pull request
Jan 29, 2025
Signed-off-by: Shailesh Singh <shaileshkumarsingh260@gmail.com> Signed-off-by: Eugene Tolbakov <ev.tolbakov@gmail.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change handles the comparison and sorting of unsigned long values during Indexing [flush and merge] operations. Since unsigned long values are stored as Java Long (and values greater than Long.MAX_VALUE turn negative), Long.compareUnsigned is used to ensure correct sorting and comparison of unsigned long dimensions. This ensures that unsigned long values are properly handled and sorted during Indexing [flush and merge] operations
Related Issues
Resolves Issue - Handle unsigned long during flush and merge operations
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.